Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for interactive sessions #180 #187

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Support for interactive sessions #180 #187

merged 1 commit into from
Nov 6, 2020

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Nov 4, 2020

No description provided.

@gnodet
Copy link
Contributor Author

gnodet commented Nov 5, 2020

This PR has a problem : the custom Prompter registered at https://github.com/gnodet/mvnd/blob/c97aeea42628b6f457805a04f6047c0568a63647/daemon/src/main/java/org/apache/maven/cli/DaemonMavenCli.java#L476-L478 is not always used by plugins. It also needs an addition integration test.

@gnodet gnodet changed the title temp Support for interactive sessions #180 Nov 5, 2020
@gnodet gnodet marked this pull request as ready for review November 6, 2020 17:22
@gnodet
Copy link
Contributor Author

gnodet commented Nov 6, 2020

A possible improvement would be to use JLine's LineReader to actually read the prompt...

@gnodet gnodet merged commit 2a0ed8f into apache:master Nov 6, 2020
@gnodet gnodet deleted the issue-180 branch November 7, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gnodet