-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All the commits are marked with a little red cross #1172
Comments
Hi @LecrisUT , I have done some research on this, and apparently, it is not possible to get a green tick on the commit when one of the experimental jobs fails. Do you mind if I remove them for now ? Thanks! |
Yes, that's one of the big annoyance with github actions. There is the all-greens action that will tell you the "true" state of the CI. But that will still show a cross on the commit itself, so yeah, can go ahead an disable them. One thing I haven't experimented is how does the CI look on scheduled builds. If that works, i.e. it is not reported, we could limit those jobs within PRs and schedules. That does mean that all of the other commits in the history will get re cross except for the merge commit. |
Thank you @LecrisUT for your understanding ! By the way I am thinking of adding a --pre run for the CI, hopefully that one will most often work! |
@mwouts can you re-open this issue? I think I've found a design for this: |
@mwouts I found the proper solution for now: You can see there that in the PR the checks are still red, but on the |
Some of the CI builds are allowed to fail, but apparently when they fail (and they always do since we test future versions), we get a red cross on the commit, like here:
The text was updated successfully, but these errors were encountered: