Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the commits are marked with a little red cross #1172

Closed
mwouts opened this issue Nov 24, 2023 · 5 comments
Closed

All the commits are marked with a little red cross #1172

mwouts opened this issue Nov 24, 2023 · 5 comments
Milestone

Comments

@mwouts
Copy link
Owner

mwouts commented Nov 24, 2023

Some of the CI builds are allowed to fail, but apparently when they fail (and they always do since we test future versions), we get a red cross on the commit, like here:
image

@mwouts mwouts added this to the 1.16.0 milestone Nov 24, 2023
@mwouts
Copy link
Owner Author

mwouts commented Nov 25, 2023

Hi @LecrisUT , I have done some research on this, and apparently, it is not possible to get a green tick on the commit when one of the experimental jobs fails. Do you mind if I remove them for now ? Thanks!

@mwouts mwouts closed this as completed Nov 25, 2023
@LecrisUT
Copy link
Contributor

Yes, that's one of the big annoyance with github actions. There is the all-greens action that will tell you the "true" state of the CI. But that will still show a cross on the commit itself, so yeah, can go ahead an disable them.

One thing I haven't experimented is how does the CI look on scheduled builds. If that works, i.e. it is not reported, we could limit those jobs within PRs and schedules. That does mean that all of the other commits in the history will get re cross except for the merge commit.

@mwouts
Copy link
Owner Author

mwouts commented Nov 27, 2023

Thank you @LecrisUT for your understanding ! By the way I am thinking of adding a --pre run for the CI, hopefully that one will most often work!

@LecrisUT
Copy link
Contributor

LecrisUT commented Dec 4, 2023

@mwouts can you re-open this issue? I think I've found a design for this:
https://stackoverflow.com/a/75987914
The plan there is after #1190, the experimental jobs will have that step included to make the CI look green on the main branch, while in the PR it will still report like normal

@LecrisUT
Copy link
Contributor

@mwouts I found the proper solution for now:
LecrisUT/CMake-Template#7

You can see there that in the PR the checks are still red, but on the main branch they're all green. In this case it was possible because I know the failing tests come from a specific step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants