Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook fails with log.showsignature=True #1281

Open
jlec opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1283
Open

pre-commit hook fails with log.showsignature=True #1281

jlec opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1283

Comments

@jlec
Copy link

jlec commented Nov 25, 2024 •
edited
Loading

When using

[log]
    showsignature = true

I am running into

[jupytext] Reading ipynb/foo.ipynb in format ipynb
Traceback (most recent call last):
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/bin/jupytext", line 8, in <module>
    sys.exit(jupytext())
             ^^^^^^^^^^
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/lib/python3.12/site-packages/jupytext/cli.py", line 497, in jupytext
    exit_code += jupytext_single_file(nb_file, args, log)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/lib/python3.12/site-packages/jupytext/cli.py", line 649, in jupytext_single_file
    notebook, inputs_nb_file, outputs_nb_file = load_paired_notebook(
                                                ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/lib/python3.12/site-packages/jupytext/cli.py", line 1125, in load_paired_notebook
    inputs, outputs = latest_inputs_and_outputs(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/lib/python3.12/site-packages/jupytext/pairs.py", line 90, in latest_inputs_and_outputs
    timestamp = get_timestamp(alt_path)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kbpd943/.cache/pre-commit/repoqsz3404t/py_env-python3.12/lib/python3.12/site-packages/jupytext/cli.py", line 1069, in git_timestamp
    return float(git_ts_str)
           ^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: 'Good "git" signature for justin with ED25519 key SHA256:PEmlDyhy3y/rM/FP7NeSBbVaIcsEg/FATEYFX5buy3Q\n1731682599'
@jlec jlec changed the title pre-commit hook fails with ssh git signatures pre-commit hook fails with log.showsignature=True Dec 7, 2024
jlec added a commit to jlec/jupytext that referenced this issue Dec 7, 2024
@jlec
fix: mwouts#1281 pre-commit fails with log.showsignature=True
dfaca5b 
Fixes mwouts#1281 by skipping the
signature in the log output
@jlec jlec linked a pull request Dec 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1281 pre-commit fails with log.showsignature=True jlec/jupytext
1 participant
@jlec