This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
add rbenv-default-gems formula #17545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. In future please use one commit (or, ideally, one pull request) per formula, use the commit format I've used above and add any useful information like you have here as a caveat. |
|
Thanks, I'll remember that for next time. |
|
There's one issue with the caveats added in 79644e1. The |
|
Ah, cheers. |
|
Fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything appears to work correctly as long as you put the
default-gemsfile in the proper location. The README states:In actuality, when installed via homebrew, the
default-gemsfile must be placed in$RBENV_ROOT(which defaults to/usr/local/opt/rbenvinstead of in~/.rbenvto be picked up correctly. It's actually makes sense but since it might not be obvious to people, maybe this needs to be added as a caveat on the formula?In the meantime, I've opened an issue rbenv/rbenv-default-gems#1 to see if the README could be clarified.