Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MadRubocop to support RuboCop 0.37 #6

Closed
ztoolson opened this issue Feb 29, 2016 · 4 comments
Closed

Upgrade MadRubocop to support RuboCop 0.37 #6

ztoolson opened this issue Feb 29, 2016 · 4 comments
Assignees

Comments

@ztoolson
Copy link
Collaborator

Currently MadRuboCop supports 0.36 version of RuboCop. Here are the new cops introduces in 0.37:

0.37.0

  • #2620: New cop Style/ZeroLengthPredicate checks for object.size == 0 and variants, and suggests replacing them with an appropriate empty? predicate.
  • Add new Style/SpaceAroundKeyword cop.
  • #2745: New cop Style/MultilineHashBraceLayout checks that the closing brace in a hash literal is symmetrical with respect to the opening brace and the hash elements.
  • #2761: New cop Style/MultilineMethodDefinitionBraceLayout checks that the closing brace in a method definition is symmetrical with respect to the opening brace and the method parameters.
  • #2766: New cop Style/MultilineMethodCallBraceLayout checks that the closing brace in a method call is symmetrical with respect to the opening brace and the method arguments.

I'm not seeing any cops that we should disable, but I'll open up the discussion. What are your thoughts?

@ztoolson
Copy link
Collaborator Author

What the upgrade looks like in newman
screen shot 2016-02-29 at 1 43 29 pm

@ztoolson
Copy link
Collaborator Author

@jarecoo
Copy link

jarecoo commented Mar 1, 2016

I'm cool with all of these.

@liveh2o
Copy link
Contributor

liveh2o commented Mar 5, 2016

Yeah, those all seem to be in line with our style guide. Let's cut a new version.

@ztoolson ztoolson mentioned this issue Mar 7, 2016
@ztoolson ztoolson self-assigned this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants