Skip to content

ChromeOS Platform type #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Basvg opened this issue Jan 17, 2025 · 3 comments · Fixed by #61
Closed

ChromeOS Platform type #54

Basvg opened this issue Jan 17, 2025 · 3 comments · Fixed by #61
Assignees

Comments

@Basvg
Copy link

Basvg commented Jan 17, 2025

Hi,

Thanks for this useful library!

I have noticed that ChromeOS is not supported as a platform. It gets detected as MacOS instead.
An example user agent: Mozilla/5.0 (X11; CrOS x86_64 15917.71.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.6533.132 Safari/537.36

It looks like it always has the CrOS in it, so I guess it would be relatively easy to detect?

@BenjaminAbt
Copy link
Member

ChromeOS support would be relatively simple

See commit b32ee86

However, ChromeOS has been discontinued and will become Android OS. The question would then be: does that even make sense? Is ChromeOS an own platform? Do we treat it as Android? Do we leave it as Linux?

cc @gfoidl

@Basvg
Copy link
Author

Basvg commented Feb 26, 2025

Thanks!

From what I have found, the discontinuation of ChromeOS is not official yet, just rumors. Also, current ChromeOS devices will be supported until at least 2035. So there will be at least 10 years that existing ChromeOS stay as it is, just newer devices might be different. I would suggest crossing that bridge whenever, if ever, it happens.

@BenjaminAbt
Copy link
Member

I will take care of it at the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants