feat(cleanup): added dedicated command #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #198 +/- ##
==========================================
- Coverage 47.54% 46.69% -0.86%
==========================================
Files 26 28 +2
Lines 2509 2557 +48
==========================================
+ Hits 1193 1194 +1
- Misses 1131 1178 +47
Partials 185 185 ☔ View full report in Codecov by Sentry. |
fritzduchardt
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Nicely done. The long description could be a touch more verbose.
As for how to integrate it into smart mode, why not run the current cleanup method every time the user renders in smart-mode?. Naturally, one would need to reinit environments first and ensure all are included in the environmentsmap.
mykso-bot
added a commit
that referenced
this pull request
Jan 7, 2024
# [3.2.0](v3.1.0...v3.2.0) (2024-01-07) ### Bug Fixes * **deps:** update github.com/cppforlife/go-cli-ui digest to 9954948 ([#201](#201)) ([9836249](9836249)) * **deps:** update golang.org/x/exp digest to be819d1 ([#204](#204)) ([9928ad1](9928ad1)) * **deps:** update module golang.org/x/sync to v0.6.0 ([#205](#205)) ([d3b8ea0](d3b8ea0)) * **deps:** update module golang.org/x/term to v0.16.0 ([#206](#206)) ([002cfe0](002cfe0)) * **sync:** allow local paths in vendir config ([#191](#191)) ([73233eb](73233eb)) ### Features * **cleanup:** added dedicated command ([#198](#198)) ([48fa589](48fa589)), closes [#130](#130) * **vendir:** embed vendir into myks ([#199](#199)) ([95ecfa8](95ecfa8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not find a clean way to integrate the cleanup into smartmode. So I added a dedicated command #130