Skip to content

feat(vendir): embed vendir into myks #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2024
Merged

feat(vendir): embed vendir into myks #199

merged 4 commits into from
Jan 1, 2024

Conversation

kbudde
Copy link
Member

@kbudde kbudde commented Dec 30, 2023

Highly experimental and open for discussion: This PR includes vendir as part of myks.
myks vendir is used as part of the sync process.

@kbudde kbudde changed the title chore(release): update docs path in goreleaser config feat(vendir): embed vendir into myks Dec 30, 2023
@kbudde

This comment was marked as resolved.

)

replace carvel.dev/vendir => github.com/mykso/vendir v0.0.0-20231230003508-84b2be48e389 // unique-tmp-dir
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is important ;)

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (053e89f) 47.54% compared to head (09c3a11) 46.93%.
Report is 1 commits behind head on dev.

Files Patch % Lines
cmd/vendir/vendir.go 0.00% 33 Missing ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
- Coverage   47.54%   46.93%   -0.62%     
==========================================
  Files          26       27       +1     
  Lines        2509     2544      +35     
==========================================
+ Hits         1193     1194       +1     
- Misses       1131     1165      +34     
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vendir is no longer needed
Now it's visible to the user that there is an embedded vendir.
@kbudde kbudde marked this pull request as ready for review December 30, 2023 20:46
Copy link
Member

@Zebradil Zebradil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is really neat, I like the idea.

I thought to embed vendir and ytt from the beginning of the project, but it was more difficult than I thought. Apart from that, those tools' maintainers suggested using binaries rather than libraries to avoid breaking changes. But it's convenient to have all the required tools shipped with myks.

I see the benefit of using vendir as a subcommand in that it provides the full functionality of vendir to the end user when it's needed. In the single place where the vendir command is used in our code, we can also invoke vendir directly without creating a sub-process. But that can come later.

I don't see any issues with the current approach so far, we should just try it for some time.

@Zebradil Zebradil merged commit 95ecfa8 into dev Jan 1, 2024
@Zebradil Zebradil deleted the vendirCmd branch January 1, 2024 09:25
mykso-bot added a commit that referenced this pull request Jan 7, 2024
# [3.2.0](v3.1.0...v3.2.0) (2024-01-07)

### Bug Fixes

* **deps:** update github.com/cppforlife/go-cli-ui digest to 9954948 ([#201](#201)) ([9836249](9836249))
* **deps:** update golang.org/x/exp digest to be819d1 ([#204](#204)) ([9928ad1](9928ad1))
* **deps:** update module golang.org/x/sync to v0.6.0 ([#205](#205)) ([d3b8ea0](d3b8ea0))
* **deps:** update module golang.org/x/term to v0.16.0 ([#206](#206)) ([002cfe0](002cfe0))
* **sync:** allow local paths in vendir config ([#191](#191)) ([73233eb](73233eb))

### Features

* **cleanup:** added dedicated command ([#198](#198)) ([48fa589](48fa589)), closes [#130](#130)
* **vendir:** embed vendir into myks ([#199](#199)) ([95ecfa8](95ecfa8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants