-
Notifications
You must be signed in to change notification settings - Fork 3
feat(vendir): embed vendir into myks #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
) | ||
|
||
replace carvel.dev/vendir => github.com/mykso/vendir v0.0.0-20231230003508-84b2be48e389 // unique-tmp-dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is important ;)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #199 +/- ##
==========================================
- Coverage 47.54% 46.93% -0.62%
==========================================
Files 26 27 +1
Lines 2509 2544 +35
==========================================
+ Hits 1193 1194 +1
- Misses 1131 1165 +34
Partials 185 185 ☔ View full report in Codecov by Sentry. |
vendir is no longer needed
Now it's visible to the user that there is an embedded vendir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is really neat, I like the idea.
I thought to embed vendir and ytt from the beginning of the project, but it was more difficult than I thought. Apart from that, those tools' maintainers suggested using binaries rather than libraries to avoid breaking changes. But it's convenient to have all the required tools shipped with myks.
I see the benefit of using vendir as a subcommand in that it provides the full functionality of vendir to the end user when it's needed. In the single place where the vendir command is used in our code, we can also invoke vendir directly without creating a sub-process. But that can come later.
I don't see any issues with the current approach so far, we should just try it for some time.
# [3.2.0](v3.1.0...v3.2.0) (2024-01-07) ### Bug Fixes * **deps:** update github.com/cppforlife/go-cli-ui digest to 9954948 ([#201](#201)) ([9836249](9836249)) * **deps:** update golang.org/x/exp digest to be819d1 ([#204](#204)) ([9928ad1](9928ad1)) * **deps:** update module golang.org/x/sync to v0.6.0 ([#205](#205)) ([d3b8ea0](d3b8ea0)) * **deps:** update module golang.org/x/term to v0.16.0 ([#206](#206)) ([002cfe0](002cfe0)) * **sync:** allow local paths in vendir config ([#191](#191)) ([73233eb](73233eb)) ### Features * **cleanup:** added dedicated command ([#198](#198)) ([48fa589](48fa589)), closes [#130](#130) * **vendir:** embed vendir into myks ([#199](#199)) ([95ecfa8](95ecfa8))
Highly experimental and open for discussion: This PR includes vendir as part of myks.
myks vendir
is used as part of the sync process.