Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement per-chart configuration #261

Closed
Zebradil opened this issue Mar 31, 2024 · 0 comments · Fixed by #310
Closed

[feat] Implement per-chart configuration #261

Zebradil opened this issue Mar 31, 2024 · 0 comments · Fixed by #310
Assignees
Labels
enhancement New feature or request

Comments

@Zebradil
Copy link
Member

Currently, the schema of myks' helm configuration looks like this:

helm:
  #! If defined, passed as `--api-version` for `helm-template`.
  capabilities:
    - "" #! e.g. "monitoring.coreos.com/v1"
  #! If true, adds `--include-crds` flag to `helm template`.
  includeCRDs: true
  #! If defined, passed as a value of `--kube-version` for `helm template`.
  kubeVersion: ""
  #! If defined, passed as a value of `--namespace` for `helm template`.
  namespace: ""
  #! If true, run "helm dependency build" before rendering. This is required for helm charts with dependencies that are pulled from git repositories.
  buildDependencies: false

These configuration values are applied to all helm charts used by an application. Being able to select different per-chart values for namespace, includeCRDs and other not yet present options can be beneficial.

The proposal is to add helm.charts key with a map of per-chart configurations (leaving the rest as it is):

helm:
  ...
  #! Per-chart configuration. The key is the name of the chart in the charts directory.
  #! Values override the global configuration.
  charts:
    httpbingo:
      includeCRDs: false
      namespace: bingo
@Zebradil Zebradil added the enhancement New feature or request label May 20, 2024
@Zebradil Zebradil self-assigned this Jun 8, 2024
@Zebradil Zebradil linked a pull request Jun 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant