Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return all content in data when no response property is defined #145

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Dec 15, 2023

Allow the response type not to be an object since it can also return any type when no data is found in the response

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ad1f64f) 92.47% compared to head (42752c9) 92.26%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/model/client/AbstractClient.ts 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   92.47%   92.26%   -0.22%     
==========================================
  Files          42       42              
  Lines        1170     1176       +6     
  Branches       88       91       +3     
==========================================
+ Hits         1082     1085       +3     
- Partials       88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine merged commit 5b6e274 into main Dec 18, 2023
5 of 6 checks passed
@EdieLemoine EdieLemoine deleted the feat/return-all-data-from-data-when-nog-response-property-is-defined branch December 18, 2023 10:22
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 18, 2023
MyParcelBot pushed a commit that referenced this pull request Dec 19, 2023
## [3.4.0](v3.3.1...v3.4.0) (2023-12-19)

### ✨ New Features

* add private endpoints ([#144](#144)) ([aed019f](aed019f))
* return all content in data when no response property is defined ([#145](#145)) ([5b6e274](5b6e274))

### 🐛 Bug Fixes

* add missing exports for endpoints ([#146](#146)) ([b3a349f](b3a349f))
@MyParcelBot
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants