fix: allow passing recipient email when posting shipments #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cysword
approved these changes
May 6, 2024
myparcel-bot
bot
force-pushed
the
fix/shipment-recipient-email
branch
from
158a0d5
to
103e09e
Compare
myparcel-bot
bot
force-pushed
the
fix/shipment-recipient-email
branch
from
103e09e
to
77a76c6
Compare
EdieLemoine
approved these changes
Jul 12, 2024
EdieLemoine
force-pushed
the
fix/shipment-recipient-email
branch
from
77a76c6
to
622b13f
Compare
EdieLemoine
force-pushed
the
fix/shipment-recipient-email
branch
from
622b13f
to
4be61ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 74 74
Lines 665 665
Branches 125 125
=======================================
Hits 520 520
Misses 20 20
Partials 125 125 ☔ View full report in Codecov by Sentry. |
myparcel-bot bot
added a commit
that referenced
this pull request
Oct 3, 2024
## [4.1.1](v4.1.0...v4.1.1) (2024-10-03) ### 🐛 Bug Fixes * allow passing recipient email when posting shipments ([#169](#169)) ([d999aeb](d999aeb)), closes [/developer.myparcel.nl/api-reference/06.shipments.html#_6-b-4](https://github.com/myparcelnl//developer.myparcel.nl/api-reference/06.shipments.html/issues/_6-b-4)
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a breaking change in the
PostShipmentrecipienttype definition after upgrading from v3.0.0, where I wasn't allowed to pass anemailfield anymore. It looks like it got introduced in #135 where therecipienttype got updated.This pull request should fix that.
I also verified that both the
emailandphonefields should still be valid fields on the recipient object here; https://developer.myparcel.nl/api-reference/06.shipments.html#_6-b-4