Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: FE-2118 - update the DeleteCarrierOptions path #170

Merged
merged 1 commit into from
May 31, 2024
Merged

fix!: FE-2118 - update the DeleteCarrierOptions path #170

merged 1 commit into from
May 31, 2024

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented May 29, 2024 •
edited by jira bot
Loading

FE-2118

The path was asking for a carrier_id while we need a contract_id

@Cysword Cysword requested review from a team as code owners May 29, 2024 15:03
@Cysword Cysword changed the title fix: update the DeleteCarrierOptions path fix!: update the DeleteCarrierOptions path May 29, 2024
@codecov Codecov
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (4d435b3) to head (d67c43e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   92.92%   92.92%   -0.01%     
==========================================
  Files          95       95              
  Lines        2247     2246       -1     
  Branches      125      125              
==========================================
- Hits         2088     2087       -1     
  Misses         34       34              
  Partials      125      125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fleurvaneijk fleurvaneijk requested a review from a team May 31, 2024 08:05
@fleurvaneijk fleurvaneijk changed the title fix!: update the DeleteCarrierOptions path fix!: FE-2118 - update the DeleteCarrierOptions path May 31, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label May 31, 2024
@Cysword Cysword added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit b56fe5a May 31, 2024
12 of 14 checks passed
@Cysword Cysword deleted the fix/update-the-delete-carrier-options-path branch May 31, 2024 08:10
myparcel-bot bot added a commit that referenced this pull request May 31, 2024
@myparcel-bot
chore(release): 4.0.0 [skip ci]
b2029c5 
## [4.0.0](v3.9.0...v4.0.0) (2024-05-31)

### ⚠ BREAKING CHANGES

* FE-2118 - update the DeleteCarrierOptions path (#170)

### 🐛 Bug Fixes

* FE-2118 - update the DeleteCarrierOptions path ([#170](#170)) ([b56fe5a](b56fe5a))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented May 31, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleurvaneijk fleurvaneijk fleurvaneijk approved these changes

@Vincentvanleeuwen Vincentvanleeuwen Vincentvanleeuwen approved these changes

Assignees

@Cysword Cysword

Labels
approved (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cysword @Vincentvanleeuwen @fleurvaneijk