Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(om): order grid shipment column options #681

Merged

Conversation

Mark-Ernst
Copy link
Contributor

No description provided.

@Mark-Ernst Mark-Ernst requested a review from a team as a code owner May 16, 2022 08:49
@Mark-Ernst Mark-Ernst changed the title Fix/order grid modal when using order management fix: order grid modal when using order management May 16, 2022
joerivanveen
joerivanveen previously approved these changes May 17, 2022
EdieLemoine
EdieLemoine previously approved these changes May 20, 2022
@@ -122,6 +131,13 @@ private function massAction()
}

if (TrackTraceHolder::EXPORT_MODE_PPS === $this->orderCollection->getExportMode()) {
foreach ($orderIds as $id) {
$orderRepositoryInterface = $this->context->getObjectManager()->get(OrderRepositoryInterface::class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uitlijnen

@Mark-Ernst Mark-Ernst dismissed stale reviews from EdieLemoine and joerivanveen via 7ff439b May 30, 2022 09:17
@Mark-Ernst Mark-Ernst force-pushed the fix/order-grid-modal-when-using-order-management branch from 4287b61 to 7ff439b Compare May 30, 2022 09:17
@joerivanveen joerivanveen changed the title fix: order grid modal when using order management fix(om): order grid shipment column options May 30, 2022
@joerivanveen joerivanveen merged commit 7a33603 into develop May 30, 2022
@joerivanveen joerivanveen deleted the fix/order-grid-modal-when-using-order-management branch May 30, 2022 09:53
MyParcelBot pushed a commit that referenced this pull request Jun 14, 2022
## [4.5.0](v4.4.0...v4.5.0) (2022-06-14)

### ✨ New Features

* add custom insurance option ([#674](#674)) ([caaee09](caaee09))
* add instabox ([#662](#662)) ([d322919](d322919))
* update shipping status orderbeheer ([#677](#677)) ([2cbb2be](2cbb2be))

### 🐛 Bug Fixes

* don't render delivery options when already visible ([#680](#680)) ([d5c084a](d5c084a))
* **om:** order grid shipment column options ([#681](#681)) ([cb7d2c0](cb7d2c0))
* **regression:** mailbox price is baseprice by itself ([#686](#686)) ([c7d07ac](c7d07ac))
* **regression:** remove instabox pickup options ([#685](#685)) ([88f2020](88f2020))
* set default carrier for row shipments ([#679](#679)) ([5f5437b](5f5437b))
* set filterable and searchable attributes to false ([#668](#668)) ([7961df1](7961df1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants