Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove attributes on uninstall #722

Merged
merged 4 commits into from
Oct 27, 2022
Merged

fix: remove attributes on uninstall #722

merged 4 commits into from
Oct 27, 2022

Conversation

Mark-Ernst
Copy link
Contributor

Resolves #720

@Mark-Ernst Mark-Ernst requested review from a team as code owners October 18, 2022 12:30
EdieLemoine
EdieLemoine requested changes Oct 19, 2022
View reviewed changes
Setup/Uninstall.php Show resolved Hide resolved
Mark-Ernst and others added 2 commits October 25, 2022 15:11
@Mark-Ernst @EdieLemoine
Update Setup/Uninstall.php
e4bf596 
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
@Mark-Ernst
fix: fix php deprecation warning
68d6f0d
@Mark-Ernst Mark-Ernst merged commit 00a17c0 into develop Oct 27, 2022
@Mark-Ernst Mark-Ernst deleted the fix/remove-attributes-on-uninstall branch October 27, 2022 11:04
MyParcelBot pushed a commit that referenced this pull request Dec 12, 2022
@semantic-release-bot
chore(release): 4.7.1 [skip ci]
fb1ea20 
## [4.7.1](v4.7.0...v4.7.1) (2022-12-12)

### 🐛 Bug Fixes

* remove instabox ([#731](#731)) ([d1c66df](d1c66df))
* remove myparcel product attributes on uninstall ([#722](#722)) ([00a17c0](00a17c0))
* remove php deprecation warning ([#721](#721)) ([23af9f8](23af9f8))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wthijmen wthijmen wthijmen approved these changes

@joerivanveen joerivanveen joerivanveen approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Ernst @MyParcelBot @EdieLemoine @joerivanveen @wthijmen