Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webhooks): fix order webhooks #225

Merged
merged 7 commits into from
Nov 8, 2023
Merged

fix(webhooks): fix order webhooks #225

merged 7 commits into from
Nov 8, 2023

Conversation

wthijmen
Copy link
Contributor

INT-212

@wthijmen wthijmen requested a review from a team as a code owner October 27, 2023 07:39
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #225 (920d2fd) into main (63b25f3) will increase coverage by 0.46%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #225      +/-   ##
============================================
+ Coverage     95.08%   95.55%   +0.46%     
+ Complexity     1577     1576       -1     
============================================
  Files           303      303              
  Lines          5390     5394       +4     
============================================
+ Hits           5125     5154      +29     
+ Misses          265      240      -25
Files Coverage Δ
src/App/Webhook/Hook/AbstractHook.php 71.42% <100.00%> (-8.58%) ⬇️
src/App/Webhook/PdkWebhookManager.php 83.72% <100.00%> (+8.72%) ⬆️

... and 10 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Mark-Ernst
Mark-Ernst reviewed Oct 27, 2023
View reviewed changes
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 27, 2023
@myparcel-bot myparcel-bot bot force-pushed the fix/webhooks branch 3 times, most recently from 8cc00ba to 59c8817 Compare October 27, 2023 13:23
EdieLemoine
EdieLemoine requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ik mis tests

@myparcel-bot myparcel-bot bot added changes requested (Auto) and removed approved (Auto) labels Oct 27, 2023
@myparcel-bot myparcel-bot bot force-pushed the fix/webhooks branch 2 times, most recently from af84b59 to e7b3c1d Compare November 1, 2023 10:48
EdieLemoine
EdieLemoine requested changes Nov 2, 2023
View reviewed changes
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
tests/Unit/App/Webhook/PdkWebhookManagerTest.php Outdated Show resolved Hide resolved
tests/Unit/App/Webhook/PdkWebhookManagerTest.php Outdated Show resolved Hide resolved
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot force-pushed the fix/webhooks branch 4 times, most recently from 91b83c9 to b83f81f Compare November 6, 2023 11:52
@myparcel-bot myparcel-bot bot force-pushed the fix/webhooks branch 4 times, most recently from 00b093f to 7e306c3 Compare November 7, 2023 08:51
@myparcel-bot myparcel-bot bot force-pushed the fix/webhooks branch 3 times, most recently from 60fee8e to 5c0e8de Compare November 7, 2023 15:29
@EdieLemoine EdieLemoine changed the title fix(webhooks): add event to hook fix(webhooks): fix order webhooks Nov 8, 2023
EdieLemoine
EdieLemoine requested changes Nov 8, 2023
View reviewed changes
src/App/Webhook/PdkWebhookManager.php Outdated Show resolved Hide resolved
tests/Unit/App/Webhook/PdkWebhookManagerTest.php Outdated Show resolved Hide resolved
tests/Unit/App/Webhook/PdkWebhookManagerTest.php Outdated Show resolved Hide resolved
tests/Unit/App/Webhook/PdkWebhookManagerTest.php Show resolved Hide resolved
@EdieLemoine EdieLemoine added this pull request to the merge queue Nov 8, 2023
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Nov 8, 2023
Merged via the queue into main with commit abe4a46 Nov 8, 2023
7 checks passed
@EdieLemoine EdieLemoine deleted the fix/webhooks branch November 8, 2023 12:59
MyParcelBot pushed a commit that referenced this pull request Nov 8, 2023
@semantic-release-bot
chore(release): 2.30.1 [skip ci]
2d591fb 
## [2.30.1](v2.30.0...v2.30.1) (2023-11-08)

### 🐛 Bug Fixes

* **webhooks:** fix order webhooks ([#225](#225)) ([abe4a46](abe4a46))
@MyParcelBot
Copy link

🎉 This PR is included in version 2.30.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Ernst Mark-Ernst Mark-Ernst approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

@joerivanveen joerivanveen Awaiting requested review from joerivanveen

Assignees

@wthijmen wthijmen

Labels
approved (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wthijmen @MyParcelBot @EdieLemoine @Mark-Ernst @joerivanveen