Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional street info is being doubled #267

Open
1 task done
PollyKant opened this issue Jul 22, 2024 · 0 comments
Open
1 task done

Additional street info is being doubled #267

PollyKant opened this issue Jul 22, 2024 · 0 comments
Labels
bug Something isn't working pdk This is a pdk related issue

Comments

@PollyKant
Copy link

Version check

  • My version of the plugin is v4.0.0-beta.0 or above.

MyParcelNL version

v4.0.0-beta.3

PrestaShop version

8.1.7

PHP version

8.1

What went wrong?

In myparcelnl/vendor/myparcelnl/pdk/src/Shipment/Request/PostShipmentsRequest.php informations included in second (optional) address fields (address2) are being doubled. Variable "street" is created by combining both address fields, and sent to MyParcelNL. Second address field is still being sent as "street_additional_info" despite the fact that it has already been included in previous data.
As a result, if optional adress field is filled, adress sent to MyParcelNL end up having format "field1 field2 field2", and this wrong address is also being printed on labels.

Reproduction steps

  1. Create an account.
  2. Create an address, fill both required and optional address field.
  3. Make an order using myparcelnl delivery method.
  4. Log in to backoffice.
  5. Go to orders page.
  6. Export order created in step 3.
  7. Log in to https://account.myparcel.nl/ account.
  8. Go to Shipments -> Summary.
  9. See "Recipient" column for an order exported in step 6.

Relevant log output

No response

Additional context

No response

@PollyKant PollyKant added the pdk This is a pdk related issue label Jul 22, 2024
@EdieLemoine EdieLemoine changed the title [BETA]: Additional street info is being doubled Additional street info is being doubled Oct 16, 2024
@EdieLemoine EdieLemoine added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdk This is a pdk related issue
Development

No branches or pull requests

2 participants