Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add carrier dhl #428

Merged
merged 27 commits into from
Dec 5, 2022
Merged

feat: add carrier dhl #428

merged 27 commits into from
Dec 5, 2022

Conversation

wthijmen
Copy link
Contributor

@wthijmen wthijmen commented Nov 21, 2022

No description provided.

@wthijmen wthijmen requested a review from a team as a code owner November 21, 2022 09:20
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #428 (1ea0caf) into main (ce8baf2) will increase coverage by 0.93%.
The diff coverage is 83.87%.

@@             Coverage Diff              @@
##               main     #428      +/-   ##
============================================
+ Coverage     42.76%   43.70%   +0.93%     
- Complexity     1693     1709      +16     
============================================
  Files            98       99       +1     
  Lines          4197     4212      +15     
============================================
+ Hits           1795     1841      +46     
+ Misses         2402     2371      -31     
Impacted Files Coverage Δ
src/Helper/MyParcelCollection.php 68.18% <ø> (ø)
src/Model/Carrier/CarrierFactory.php 88.00% <ø> (ø)
...DeliveryOptions/AbstractShipmentOptionsAdapter.php 50.81% <50.00%> (-0.21%) ⬇️
src/Model/Consignment/DHLForYouConsignment.php 80.00% <80.00%> (ø)
src/Services/ConsignmentEncode.php 69.64% <92.85%> (+0.69%) ⬆️
src/Adapter/ConsignmentAdapter.php 97.36% <100.00%> (+0.10%) ⬆️
...apter/DeliveryOptions/ShipmentOptionsV3Adapter.php 100.00% <100.00%> (ø)
src/Model/Consignment/AbstractConsignment.php 75.42% <100.00%> (+2.01%) ⬆️
...ator/Consignment/DHLForYouConsignmentValidator.php 100.00% <100.00%> (ø)
src/Model/Consignment/InstaboxConsignment.php
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoals besproken worden de tests nog werkend gemaakt en coverage verbeterd.

src/Model/Carrier/CarrierDHLForYou.php Outdated Show resolved Hide resolved
joerivanveen
joerivanveen previously approved these changes Nov 25, 2022
src/Model/Consignment/AbstractConsignment.php Outdated Show resolved Hide resolved
Mark-Ernst
Mark-Ernst previously approved these changes Nov 25, 2022
src/Model/Consignment/AbstractConsignment.php Outdated Show resolved Hide resolved
Mark-Ernst
Mark-Ernst previously approved these changes Nov 25, 2022
@EdieLemoine EdieLemoine merged commit d1d56cf into main Dec 5, 2022
@EdieLemoine EdieLemoine deleted the feat/add-carrier-dhl branch December 5, 2022 11:54
MyParcelBot pushed a commit that referenced this pull request Dec 5, 2022
## [7.5.0](v7.4.4...v7.5.0) (2022-12-05)

### ✨ New Features

* add carrier dhl ([#428](#428)) ([d1d56cf](d1d56cf))
@MyParcelBot
Copy link

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

joerivanveen pushed a commit that referenced this pull request Mar 14, 2024
joerivanveen pushed a commit that referenced this pull request Mar 14, 2024
## [7.5.0](v7.4.4...v7.5.0) (2022-12-05)

### ✨ New Features

* add carrier dhl ([#428](#428)) ([d1d56cf](d1d56cf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants