Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make shipmentOptions and pickupLocation properties snake_case for backwards compatibility #481

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Apr 16, 2024

INT-449

@joerivanveen joerivanveen force-pushed the fix/prevent-camel-cased-options-from-breaking-order-detail-page branch from 4cc83aa to a72bfc4 Compare April 18, 2024 18:58
@joerivanveen joerivanveen changed the title fix: prevent camel cased options from breaking order detail page fix: make shipmentOptions and pickupLocation properties snake_case for backwards compatibility Apr 18, 2024
@joerivanveen joerivanveen marked this pull request as ready for review April 18, 2024 19:03
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.21%. Comparing base (f1b9221) to head (6da75c9).
Report is 5 commits behind head on main.

Files Patch % Lines
src/Factory/DeliveryOptionsAdapterFactory.php 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #481      +/-   ##
============================================
+ Coverage     58.88%   59.21%   +0.33%     
- Complexity     1807     1810       +3     
============================================
  Files           112      110       -2     
  Lines          4295     4293       -2     
============================================
+ Hits           2529     2542      +13     
+ Misses         1766     1751      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerivanveen joerivanveen added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@joerivanveen joerivanveen added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit f4ec38d Apr 22, 2024
4 checks passed
@joerivanveen joerivanveen deleted the fix/prevent-camel-cased-options-from-breaking-order-detail-page branch April 22, 2024 12:45
MyParcelBot pushed a commit that referenced this pull request Apr 22, 2024
## [7.13.1](v7.13.0...v7.13.1) (2024-04-22)

### 🐛 Bug Fixes

* make shipmentOptions and pickupLocation properties snake_case for backwards compatibility ([#481](#481)) ([f4ec38d](f4ec38d))
@MyParcelBot
Copy link

🎉 This PR is included in version 7.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants