Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better solution not to include PJON lib into MySensors repo #1516

Open
virtual-maker opened this issue Feb 9, 2022 · 2 comments
Open

Comments

@virtual-maker
Copy link
Contributor

virtual-maker commented Feb 9, 2022

There are two main problems with the newly included PJON library:

  1. The addition seems to break the CI and let always fail the "Toll gate" step.
  2. The included PJON library is practically a fork which makes it difficulty to sync it with the original PJON lib.

Current discussion:

  • "I personally dislike the idea to include this big external PJON library into the MySensors lib repo. May be an other solution by use of an external library reference would be better."

  • "The Arduino IDE does not handle dependencies (at least not in an useful way). This has caused a lot of problems for MySensors users. The least bad way we’ve found so far is to include all code in the same repo. But that also means that we in effect fork every dependency, which sucks."

  • "I’m not sure how we should handle the PJON case. I’ll think about it and see if there is something I think could work better."

Ideas and suggestions are very welcome.

Originally posted by @mfalkvidd in #1515 (comment)

@mfalkvidd
Copy link
Member

Related: mysensors/MySensorsArduinoExamples#52

@mfalkvidd
Copy link
Member

__has_include() might be useful, to display a user-friendly message with instruction on which library to install and how to install it.

But we still wouldn't know which version the included library is (unless the library itself has some define that determines the version) which makes it hard to ensure compatibility. Whenever the upstream library has breaking changes, MySensors users would be left clueless.

The same issue applies to TinyGSM, https://forum.mysensors.org/topic/12003/gsm-mqtt-gateway-can-we-update-the-tinygsm-library-used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants