-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider whether or not public body tags should be case sensitive #5307
Comments
Moved to https://github.com/mysociety/alaveteli as we'd make this change for all Alavetelis. I think enforcing lower case would be easiest. We could ignore case on comparison, but that would be quite a faff in the code I think. |
This would seem to make sense. On WDTK we only have a couple of tags which are specifically in another case (three that come to mind are CRC, LEP, and, RFCAs); others are a byproduct of what could perhaps be considered a stylistic preference. Provided enforcement wouldn't cause a specific issues with existing bodies, I can't see any issue in this approach. 🙂 |
If tags ever appear to the public then proper capitalisation of eg. Scotland would be preferable. |
Tags don't currently appear to the public I don't think. Only categories do (tags where a description of what the tag is for exists), so we only show the properly capitalised. If tags are kept largely behind the scenes then maybe all lowercase is OK. |
The Scotland / scotland issue in the initial issue description here has already been fixed. We could propose a developer action to make all existing tags lowercase, then enforce lowercase from now on? |
In the case of key:value tags there might be values which have elements which should be uppercase. It might be safer to leave such values mixed case? eg. a company number "SC327000" - is it important the SC is capitalised? What about an NHS ODS code eg. YGMXK I don't think in either of those cases we'd break anything by going lowercase, but we might lose something, as the codes are capitalised on the official registers. |
Agreed - some of the datasources we use may very well be case sensitive, so it makes sense that the 'value' string honours whichever format the source uses. There are some surprising examples of database query systems which are case sensitive, both in and out of public sector! |
The National Archives convert to lowercase.
|
This issue has been automatically closed due to a lack of discussion or resolution for over 12 months. |
Originally posted by @RichardTaylor in mysociety/whatdotheyknow-theme#582 (comment) #582
The text was updated successfully, but these errors were encountered: