Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether or not public body tags should be case sensitive #5307

Closed
mdeuk opened this issue Jul 17, 2019 · 9 comments
Closed

Consider whether or not public body tags should be case sensitive #5307

mdeuk opened this issue Jul 17, 2019 · 9 comments
Labels
f:authorities improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months x:uk

Comments

@mdeuk
Copy link
Collaborator

mdeuk commented Jul 17, 2019

Originally posted by @RichardTaylor in mysociety/whatdotheyknow-theme#582 (comment) #582

We have a more general issue with tags being case sensitive and admins sometimes introducing something inconsistent eg. at the time of writing we have 8 public bodies tagged

https://www.whatdotheyknow.com/body?tag=Scotland
and 540 tagged
https://www.whatdotheyknow.com/body?tag=scotland

Should we enforce lower case on tags?

@garethrees garethrees transferred this issue from mysociety/whatdotheyknow-theme Jul 18, 2019
@garethrees garethrees added f:authorities improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk labels Jul 18, 2019
@garethrees
Copy link
Member

Moved to https://github.com/mysociety/alaveteli as we'd make this change for all Alavetelis.

I think enforcing lower case would be easiest. We could ignore case on comparison, but that would be quite a faff in the code I think.

@mdeuk
Copy link
Collaborator Author

mdeuk commented Jul 18, 2019

Moved to https://github.com/mysociety/alaveteli as we'd make this change for all Alavetelis.

I think enforcing lower case would be easiest. We could ignore case on comparison, but that would be quite a faff in the code I think.

This would seem to make sense. On WDTK we only have a couple of tags which are specifically in another case (three that come to mind are CRC, LEP, and, RFCAs); others are a byproduct of what could perhaps be considered a stylistic preference.

Provided enforcement wouldn't cause a specific issues with existing bodies, I can't see any issue in this approach. 🙂

@RichardTaylor
Copy link

If tags ever appear to the public then proper capitalisation of eg. Scotland would be preferable.

@RichardTaylor
Copy link

If tags ever appear to the public then proper capitalisation of eg. Scotland would be preferable.

Tags don't currently appear to the public I don't think. Only categories do (tags where a description of what the tag is for exists), so we only show the properly capitalised. If tags are kept largely behind the scenes then maybe all lowercase is OK.

@RichardTaylor
Copy link

The Scotland / scotland issue in the initial issue description here has already been fixed.

We could propose a developer action to make all existing tags lowercase, then enforce lowercase from now on?

@RichardTaylor
Copy link

In the case of key:value tags there might be values which have elements which should be uppercase.

It might be safer to leave such values mixed case?

eg. a company number "SC327000" - is it important the SC is capitalised?

What about an NHS ODS code eg. YGMXK

I don't think in either of those cases we'd break anything by going lowercase, but we might lose something, as the codes are capitalised on the official registers.

@mdeuk
Copy link
Collaborator Author

mdeuk commented Oct 29, 2021

In the case of key:value tags there might be values which have elements which should be uppercase.
...
I don't think in either of those cases we'd break anything by going lowercase, but we might lose something, as the codes are capitalised on the official registers.

Agreed - some of the datasources we use may very well be case sensitive, so it makes sense that the 'value' string honours whichever format the source uses.

There are some surprising examples of database query systems which are case sensitive, both in and out of public sector!

@garethrees
Copy link
Member

The National Archives convert to lowercase.

Review your tags. Please be aware that tags will be saved and displayed in lowercase letters to maintain standardisation and consistency.

@HelenWDTK
Copy link
Contributor

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.

@HelenWDTK HelenWDTK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:authorities improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months x:uk
Projects
None yet
Development

No branches or pull requests

4 participants