Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes to outgoing and incoming messages #7302

Closed
garethrees opened this issue Sep 13, 2022 · 4 comments · May be fixed by #8133
Closed

Add notes to outgoing and incoming messages #7302

garethrees opened this issue Sep 13, 2022 · 4 comments · May be fixed by #8133
Labels
enhancement Adds new functionality f:notes stale Issues with no activity for 12 months x:uk

Comments

@garethrees
Copy link
Member

garethrees commented Sep 13, 2022 •
edited
Loading

It's good to be able to be as precise as possible with our admin actions. For example, we try to minimise information removal by applying the least destructive approach possible (censor rule -> prominence of individual attachment -> prominence of individual message… and so on).

By the same token, it would be useful to add an explanatory note to a specific message rather than the whole request.

The context here is that I'm looking at an incoming issue from an authority saying they've released inaccurate material by mistake. They've followed up with a replacement. It would be good to use the directly attached/note via tag approach to mark this as "inaccurate" but not something we'll remove.

SEO: notable, noteable, tag based notes.
@garethrees garethrees added x:uk enhancement Adds new functionality f:notes labels Sep 13, 2022
@mdeuk
Copy link
Collaborator

mdeuk commented Sep 13, 2022

+1, this is something I've wished we could do for quite some time.

Another use-case would be the "the authority responded with a link to download the file - we've put it on our fileserver" messages that we currently apply as annotations. These are done with the best of intentions, but can get lost in a thread containing multiple messages, so it'd be helpful to put them in the viewer's eyeline as they are reading the relevant message.

@FOIMonkey
Copy link
Collaborator

+1 This could also help us to note admin actions, particularly if we get #1005

@garethrees
Copy link
Member Author

Quickly stubbing this out in web inspector to see how we might position it:

Between the header and correspondence_text

Screenshot 2022-09-13 at 14 36 45

<aside id="notes">
<div class="correspondence_text">
  <p>Foo bar baz Foo bar baz Foo bar baz</p>

Within the correspondence_text

Screenshot 2022-09-13 at 14 37 04

<div class="correspondence_text">
  <aside id="notes">
  <p>Foo bar baz Foo bar baz Foo bar baz</p>

@garethrees garethrees mentioned this issue Mar 28, 2023
Closed
@garethrees garethrees mentioned this issue Oct 17, 2023
Closed
@HelenWDTK HelenWDTK mentioned this issue Feb 16, 2024
Draft
@HelenWDTK HelenWDTK linked a pull request Feb 16, 2024 that will close this issue
7302 add notes to outgoing and incoming messages #8133
Draft
@HelenWDTK HelenWDTK added the stale Issues with no activity for 12 months label Nov 19, 2024
@HelenWDTK
Copy link
Contributor

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.

@HelenWDTK HelenWDTK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adds new functionality f:notes stale Issues with no activity for 12 months x:uk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7302 add notes to outgoing and incoming messages mysociety/alaveteli
4 participants
@mdeuk @garethrees @FOIMonkey @HelenWDTK