Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comparators for "Friends of the Earth local action groups" dataset #495

Open
zarino opened this issue Mar 4, 2024 · 1 comment · May be fixed by #510
Open

Wrong comparators for "Friends of the Earth local action groups" dataset #495

zarino opened this issue Mar 4, 2024 · 1 comment · May be fixed by #510
Labels
bug This is a bug that is affecting real users data import

Comments

@zarino
Copy link
Member

zarino commented Mar 4, 2024

"Friends of the Earth local action groups" dataset (constituency_foe_groups) only has "contains" comparators. Which is a bit odd? Especially when the default value is {}!

Screenshot 2024-03-04 at 11 56 43

Either this should be a numeric comparator, like the "Friends of the Earth activists" dataset (constituency_foe_activists_count) in future constituencies:

Screenshot 2024-03-04 at 11 58 03

Or we should have a separate "Number of…" dataset, with a numeric type rather than JSON data type, like we do for Womens Institute groups (constituency_wi_group_count), for example:

Screenshot 2024-03-04 at 12 02 31

@zarino zarino added bug This is a bug that is affecting real users data import labels Mar 4, 2024
@struan struan linked a pull request Mar 14, 2024 that will close this issue
@struan
Copy link
Member

struan commented Mar 14, 2024

This should not have been filterable. I've updated this in the database and there's a fix in #510.

There is a ticket (#490) on adding a JSON comparator but it's not straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug that is affecting real users data import
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants