-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DbDataReader for non-query commands #28
Comments
Most providers currently just return |
@bgrainger I think the logic for returning null in this situation is that (dynamic) API consumers may not be aware of whether the command was supposed to return a resultset or not. Telling them to call the API and catch the exception isn't good (i.e. use of exceptions for regular flow control). On the other hand I do agree that using null to indicate no rows isn't ideal (am thinking ahead to when we null-annotate the ADO.NET surface API). We could tell consumers to check FieldCount first, and that calling |
I uncovered a new nest of scenarios that would be good to add coverage for in dotnet/efcore#16053
The text was updated successfully, but these errors were encountered: