-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default namespace to MySqlConnector #824
Comments
So long |
This library has proven its worth and the user will use it accordingly (even with Namespace change). If I am to weigh the PROS and CONS above, I would gladly like to choose the benefits of the PROS above. My use case of having an ORM that could abstract both library is quite unique (so for others), but it would help me a lot when it comes to maintainability, operation-wise and simplicity. The use-case of combining both libraries (i.e: MySql.Data and MySqlConnector) is a quite good use-case in which you do not limit the users to explicitly remove the other. I would suggest it will start from here unless Oracle decided to not coincide on this tool. |
My 2 cents in favor of this change:
This is a change that should bump the version to 1.0 or even 2.0. |
+1! |
This reopens #189.
Poll: Please vote 👍 or 👎 on this issue if you'd like to see this implemented (or not).
In the past, MySqlConnector was simply trying to become a replacement for MySQL Connector/NET, and cloning its API (down to the namespace) seemed like an easy way to displace it, by providing a simple upgrade path. But as the list of known Connector/NET bugs and edge cases has grown, MySqlConnector has chosen to become incompatible in an increasing number of ways. Thus it's much less true that a user can upgrade by just changing their NuGet package reference and none of their code.
Additionally, MySqlConnector is now pushing the API forward (async, batching, bulk copy, etc.) beyond what Connector/NET supports. It makes sense for these new features (that are "defined" by MySqlConnector) to be in their own namespace (instead of in a namespace where they might one day conflict with Connector/NET if it ever implemented those classes slightly differently).
Finally, while it's possible to use both MySqlConnector and MySql.Data in the same project, it's difficult and it impacts all consumers of that project: mikependon/RepoDB#375 (comment).
Pros
MySqlHelper
) could move out of the main namespaceCons
The text was updated successfully, but these errors were encountered: