You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that url.parse and others as part of the Legacy URL API are no longer deprecated as of node v14.17.0. I don't believe they should trigger node/no-deprecated-api.
This was specifically an issue in our projects given than url.parse(path) is not the same as new URL(path) when the path is relative. See issues for more:
Still do not think that ppl should use url.parse as it's not as well cross env. friendly. new URL() exist in every env. url.parse don't (it requires a polyfill)
It's fine if developers/teams decide not to use url.parse as a matter of best practice but the fact remains that it is not actually deprecated and thus should not trigger the no-deprecated-api rule. This is important because new URL() is not a direct replacement for url.parse in certain circumstances (see above) and the no-deprecated-api error forced us to change code that didn't technically need changed for a deprecated function.
It seems that
url.parse
and others as part of the Legacy URL API are no longer deprecated as of nodev14.17.0
. I don't believe they should triggernode/no-deprecated-api
.This was specifically an issue in our projects given than
url.parse(path)
is not the same asnew URL(path)
when the path is relative. See issues for more:The text was updated successfully, but these errors were encountered: