Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plus sign missing #398

Merged
merged 1 commit into from
Jul 7, 2018
Merged

fix: plus sign missing #398

merged 1 commit into from
Jul 7, 2018

Conversation

muzea
Copy link
Contributor

@muzea muzea commented Jul 4, 2018

There are some configurations that use webpack.DefinePlugin to define ENV. If use process.env.NODE_ENV, will get undefined. Do need to explain it in the documentation?

@mzgoddard
Copy link
Owner

@muzea Thank you for catching that omission.

@mzgoddard mzgoddard merged commit 8885f10 into mzgoddard:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants