-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to zmq-prebuilt 2.x #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Tested on a 32b-linux machine and the fallback works! @lgeiger Great work! Is this or zmq-static ready for Hydrogen? |
Since I'm unfamiliar with your process - will this be posted with |
Could we rely on |
@rgbkrk This PR's already published as Is I'm also guessing from your question about |
Yes!
This is correct.
We're going to try to, over time. Right now the process of getting things in, adjusting AppVeyor (and shipped assets), and anything involving settings on the |
I feel a bit queasy about the idea of maintaining I will release this PR as |
We have prebuilt binaries working for Linux, OS X and Windows.
zmq-prebuilt
can now be built from source as well to support rebuilding with different electron versions. In other words the fallback works 🎉.