Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Clarify expected cache headers #190

Closed
Tracked by #173
fabricedesre opened this issue Sep 7, 2022 · 2 comments
Closed
Tracked by #173

Clarify expected cache headers #190

fabricedesre opened this issue Sep 7, 2022 · 2 comments

Comments

@fabricedesre
Copy link
Contributor

From discord:

[10:46 AM] fabrice:
why is "no-cache" used for the default cache header value? 
[10:59 AM] Arqu:
Lots of those bits are still not fully fleshed out
[10:59 AM] Arqu:
Technically we cache everything if the store is present
[11:00 AM] Arqu:
But we dont handle the etags and cache headers fully so it doesnt make sense we advertise anything else
[11:00 AM] Arqu:
The blessing with content addressed storage is you can cache a cid indefinitely technically as the contents wont change
[11:01 AM] Arqu:
And you never cache ipns type reqs

I'm not sure if it's worth exposing cache headers as configurable. As @Arqu says, behavior needs to different between /ipfs and /ipns. For raw and car response, we should return Cache-Control: immutable.

Thoughts?

@fabricedesre
Copy link
Contributor Author

@Arqu
Copy link
Collaborator

Arqu commented Oct 9, 2022

Spec is already being followed, in the next update the misleading flags will be removed. The only exception is that for the IPNS based Last-Modified date we follow what kubo does instead of taking the spec recommendation to either do dns ttl based dates or not at all.

@Arqu Arqu closed this as completed Oct 9, 2022
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants