Skip to content

Commit d43d474

Browse files
authored
tests(iroh-net-report): Do not ping hosts on the internet (#3172)
## description No matter what we do, pinging hosts on the internet is flaky, packets do get lost. We only care that we manage to send and receive pings correctly, which we fully do by pinging localhost. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
1 parent 9eccb05 commit d43d474

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

iroh-net-report/src/ping.rs

-29
Original file line numberDiff line numberDiff line change
@@ -128,35 +128,6 @@ mod tests {
128128

129129
use super::*;
130130

131-
#[tokio::test]
132-
#[ignore] // Doesn't work in CI
133-
#[traced_test]
134-
async fn test_ping_google() -> Result<()> {
135-
// Public DNS addrs from google based on
136-
// https://developers.google.com/speed/public-dns/docs/using
137-
138-
let pinger = Pinger::new();
139-
140-
// IPv4
141-
let dur = pinger.send("8.8.8.8".parse()?, &[1u8; 8]).await?;
142-
assert!(!dur.is_zero());
143-
144-
// IPv6
145-
match pinger
146-
.send("2001:4860:4860:0:0:0:0:8888".parse()?, &[1u8; 8])
147-
.await
148-
{
149-
Ok(dur) => {
150-
assert!(!dur.is_zero());
151-
}
152-
Err(err) => {
153-
tracing::error!("IPv6 is not available: {:?}", err);
154-
}
155-
}
156-
157-
Ok(())
158-
}
159-
160131
// See net_report::reportgen::tests::test_icmp_probe_eu_relay for permissions to ping.
161132
#[tokio::test]
162133
#[traced_test]

0 commit comments

Comments
 (0)