-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh-net): Send HTTP/1.1 HOST
header on requests to relay
#2881
Conversation
@link2xt please try out this PR and let us know if it helps ✌️ |
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2881/docs/iroh/ Last updated: 2024-11-04T08:32:35Z |
That's a bit strange explanation. I already know at my reverse proxy where I want to forward requests, it's just that Host header is required by HTTP/1.1 standard and nginx is strict about enforcing it. |
I can see that reading strange to you. I adjusted the PR description to hopefully clarify. |
Tested, can connect to the relay over nginx proxy now. |
Description
Reverse proxies that map multiple virtual hosts need some help to know where to forward requests to.
That's what the
HOST
header is for, and it's mandatory for HTTP/1.1 requests.Closes #2870
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] All breaking changes documented.