Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh-relay)!: Remove usesed errors. #3012

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

flub
Copy link
Contributor

@flub flub commented Dec 5, 2024

Description

A whole bunch of these errors are unused. But they are all pub so the
compiler doesn't tell us. :'(

Breaking Changes

iroh-relay

  • ClientError has a number of unused variants removed.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Sorry, something went wrong.

A whole bunch of these errors are unused.  But they are all pub so the
compiler doesn't tell us. :'(
@flub flub changed the title refactor(iroh-relay): Remove usesed errors. refactor(iroh-relay)!: Remove usesed errors. Dec 5, 2024
@flub flub requested a review from a team December 5, 2024 09:33
@flub flub enabled auto-merge December 5, 2024 09:33
Copy link

github-actions bot commented Dec 5, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3012/docs/iroh/

Last updated: 2024-12-05T09:36:13Z

Copy link

github-actions bot commented Dec 5, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 2593a99

@flub flub added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c5d9e68 Dec 5, 2024
30 of 31 checks passed
@flub flub deleted the flub/unused-errors branch December 5, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants