Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date internationalization, common formats #401

Open
victor-shelepen opened this issue Jan 10, 2016 · 4 comments
Open

date internationalization, common formats #401

victor-shelepen opened this issue Jan 10, 2016 · 4 comments
Labels

Comments

@victor-shelepen
Copy link

In the previous version v1 I used common date formats. I passed the the formatter according d3 documentation. ticksFormat: '%m/%d' It stops working. It seems you preprocess settings filtering them.

@chaosmail
Copy link
Contributor

Yep you are right, just saw this line is commented out in https://github.com/n3-charts/line-chart/blob/master/src/factories/Axis.ts#L233
@lorem--ipsum is this just a linting problem or something seriouis?

@chaosmail chaosmail added the bug label Jan 10, 2016
@chaosmail
Copy link
Contributor

@VLikin we will fix this as soon as possible!

@lorem--ipsum
Copy link
Member

The line is commented out because of a linting problem, however it shouldn't be a problem in this specific case since the clone method is called for the grid only.

@naduda
Copy link

naduda commented Mar 14, 2016

It's an angularjs directive and i think right way create type like as angularjs filter.
For example, type: 'date:dd.MM.yyyy:+0430'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants