Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars change even if onChange fails and the value does not change #45

Open
s7dhansh opened this issue Jan 13, 2018 · 0 comments
Open

Stars change even if onChange fails and the value does not change #45

s7dhansh opened this issue Jan 13, 2018 · 0 comments

Comments

@s7dhansh
Copy link

If the star value remains unchanged even after clicking the stars (due to a failure in the onChange method or otherwise), the stars retain their changed state, instead of reverting to the original.

I think

stars = Math.round(this.state.value)
must have this.props.value and not this.state.value. Let me know and I can push a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant