Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Contentful Node): Add missing additional fields to entry > get #10830

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Sep 16, 2024

Summary

Entry > Get was missing additional Fields which was stopping the resource operation / action from working. Not added test as it is a missing UI option.

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/unable-to-configure-contentful-node-to-get-entry-by-entryid/53442
https://linear.app/n8n/issue/NODE-1728/contentful-additional-fields-missing

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 16, 2024
@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Sep 17, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 17, 2024

n8n    Run #6920

Run Properties:  status check passed Passed #6920  •  git commit 8f14041189: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-1728-contentful-additional-fields-missing
Run status status check passed Passed #6920
Run duration 04m 42s
Commit git commit 8f14041189: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit c43aef1 into master Sep 17, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1728-contentful-additional-fields-missing branch September 17, 2024 15:28
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with n8n@1.60.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released tests-needed This PR needs additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants