Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Remove subworkflow license check #10893

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

despairblue
Copy link
Contributor

@despairblue despairblue commented Sep 19, 2024

Summary

This led constantly to issues when the license got out of sync between the main instance and the worker.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-1902

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@despairblue despairblue added the release/backport Changes that need to be backported to older releases. label Sep 19, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 19, 2024
@despairblue despairblue marked this pull request as ready for review September 23, 2024 08:54
Copy link

cypress bot commented Sep 23, 2024

n8n    Run #7006

Run Properties:  status check passed Passed #7006  •  git commit 0d64243e11: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project n8n
Branch Review remove-subworkflow-license-check
Run status status check passed Passed #7006
Run duration 04m 52s
Commit git commit 0d64243e11: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Committer Danny Martini
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@despairblue despairblue merged commit 0290e38 into master Sep 23, 2024
33 checks passed
@despairblue despairblue deleted the remove-subworkflow-license-check branch September 23, 2024 15:01
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

ivov added a commit to n8n-io/n8n-docs that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants