Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable Assistant on other credential views #10931

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: Enable Assistant on other credential views #10931

merged 1 commit into from
Sep 23, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Sep 23, 2024 •
edited by MiloradFilipovic
Loading

Summary

Enable Assistant on other credential views (project credentials, template credentials)

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-2620

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mutdmour mutdmour marked this pull request as ready for review September 23, 2024 11:00
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 23, 2024
MiloradFilipovic
MiloradFilipovic approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Love the tests

@cypress Cypress
Copy link

cypress bot commented Sep 23, 2024

n8n    Run #7001

Run Properties:  status check passed Passed #7001  •  git commit 799a40ad27: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review ADO-2620
Run status status check passed Passed #7001
Run duration 04m 27s
Commit git commit 799a40ad27: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 557db9c into master Sep 23, 2024
34 checks passed
@mutdmour mutdmour deleted the ADO-2620 branch September 23, 2024 12:06
riascho pushed a commit that referenced this pull request Sep 24, 2024
@mutdmour @riascho
fix: Enable Assistant on other credential views (#10931)
5ab8827
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees

@mutdmour mutdmour

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @MiloradFilipovic