Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Keep always focus on the first item on the node's search panel #11193

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Oct 10, 2024

Summary

The issue only happened when there was an AI node in the workflow.

Before:

image

After:

image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title fix focus when searching for nodes fix(editor-ui): Keep always focus on the first item on the node's search panel Oct 10, 2024
@RicardoE105 RicardoE105 changed the title fix(editor-ui): Keep always focus on the first item on the node's search panel fix(editor): Keep always focus on the first item on the node's search panel Oct 10, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 10, 2024
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, not sure what was the removed logic doing tho.
So maybe @OlegIvaniv can also take a quick look?

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 17, 2024

n8n    Run #7416

Run Properties:  status check passed Passed #7416  •  git commit c57cac9e4d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7416
Run duration 04m 26s
Commit git commit c57cac9e4d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 453

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit c57cac9 into master Oct 17, 2024
33 checks passed
@RicardoE105 RicardoE105 deleted the ado-2401-node-panel-does-have-second-node-selected-by-default-when branch October 17, 2024 19:51
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with n8n@1.65.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants