-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Keep always focus on the first item on the node's search panel #11193
Merged
RicardoE105
merged 3 commits into
master
from
ado-2401-node-panel-does-have-second-node-selected-by-default-when
Oct 17, 2024
Merged
fix(editor): Keep always focus on the first item on the node's search panel #11193
RicardoE105
merged 3 commits into
master
from
ado-2401-node-panel-does-have-second-node-selected-by-default-when
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
fix focus when searching for nodes
fix(editor-ui): Keep always focus on the first item on the node's search panel
Oct 10, 2024
RicardoE105
changed the title
fix(editor-ui): Keep always focus on the first item on the node's search panel
fix(editor): Keep always focus on the first item on the node's search panel
Oct 10, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 10, 2024
…selected-by-default-when
MiloradFilipovic
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, not sure what was the removed logic doing tho.
So maybe @OlegIvaniv can also take a quick look?
✅ All Cypress E2E specs passed |
OlegIvaniv
approved these changes
Oct 17, 2024
|
…selected-by-default-when
fedme
approved these changes
Oct 17, 2024
n8n Run #7416
Run Properties:
|
Project |
n8n
|
Run status |
Passed #7416
|
Run duration | 04m 26s |
Commit |
c57cac9e4d: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
453
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-2401-node-panel-does-have-second-node-selected-by-default-when
branch
October 17, 2024 19:51
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue only happened when there was an AI node in the workflow.
Before:
After:
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)