Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Fix tool parameter parsing issue #11201

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Oct 10, 2024

Summary

This PR adds a fix to the OpenAI Node's tool parameter parsing logic. It should improve reliability of the tool calling.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/AI-385/community-issue-http-tool-does-not-work-correctly-with-openai-node
https://community.n8n.io/t/issue-with-http-request-tool/56719

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@burivuhster burivuhster marked this pull request as ready for review October 10, 2024 10:58
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Oct 10, 2024
Copy link

cypress bot commented Oct 10, 2024

n8n    Run #7303

Run Properties:  status check passed Passed #7303  •  git commit 3f8fb32e1f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7303
Run duration 04m 30s
Commit git commit 3f8fb32e1f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437

Copy link
Contributor

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit 5a1d81a into master Oct 10, 2024
54 checks passed
@burivuhster burivuhster deleted the ai-385-community-issue-http-tool-does-not-work-correctly-with branch October 10, 2024 11:50
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
@janober
Copy link
Member

janober commented Oct 16, 2024

Got released with n8n@1.64.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants