Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Set Node): Fix issue with UI properties not being hidden #11263

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Oct 15, 2024

Summary

This hides the exclude / include fields box when include other input fields is disabled.

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/bugreport-editfields-node-not-properly-hiding-input-field/57647

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@Joffcom Joffcom changed the title fix(Edit Fields (Set) Node): Fix issue with UI properties not being hidden fix(Set Node): Fix issue with UI properties not being hidden Oct 15, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 15, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Oct 15, 2024

n8n    Run #7366

Run Properties:  status check passed Passed #7366  •  git commit e00b5e0e12: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7366
Run duration 04m 23s
Commit git commit e00b5e0e12: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 1affc27 into master Oct 15, 2024
51 checks passed
@ShireenMissi ShireenMissi deleted the node-1875-set-node-field-not-hidden branch October 15, 2024 13:33
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
@janober
Copy link
Member

janober commented Oct 16, 2024

Got released with n8n@1.64.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants