-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Fix delete all existing executions #11352
Merged
cstuncsik
merged 5 commits into
master
from
pay-2056-community-issue-select-all-finished-executions-delete-off-by
Oct 23, 2024
Merged
fix(editor): Fix delete all existing executions #11352
cstuncsik
merged 5 commits into
master
from
pay-2056-community-issue-select-all-finished-executions-delete-off-by
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 22, 2024
r00gm
approved these changes
Oct 23, 2024
n8n Run #7523
Run Properties:
|
Project |
n8n
|
Branch Review |
pay-2056-community-issue-select-all-finished-executions-delete-off-by
|
Run status |
Passed #7523
|
Run duration | 04m 22s |
Commit |
799d916b77: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
|
Committer | Csaba Tuncsik |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
458
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-2056-community-issue-select-all-finished-executions-delete-off-by
branch
October 23, 2024 10:46
MarcL
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and fixes the issue. Thanks.
✅ All Cypress E2E specs passed |
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Delete all existing executions cannot be done at once.
It works by deleting everything before a date and using the latest execution's 'startedAt' property is not inclusive.
Related Linear tickets, Github issues, and Community forum posts
PAY-2056
Fixes #11115
Review / Merge checklist
release/backport