Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix delete all existing executions #11352

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Oct 22, 2024

Summary

Delete all existing executions cannot be done at once.
It works by deleting everything before a date and using the latest execution's 'startedAt' property is not inclusive.

Related Linear tickets, Github issues, and Community forum posts

PAY-2056

Fixes #11115

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 22, 2024
@cstuncsik cstuncsik marked this pull request as ready for review October 23, 2024 09:17
Copy link

cypress bot commented Oct 23, 2024

n8n    Run #7523

Run Properties:  status check passed Passed #7523  •  git commit 799d916b77: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2056-community-issue-select-all-finished-executions-delete-off-by
Run status status check passed Passed #7523
Run duration 04m 22s
Commit git commit 799d916b77: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 3ec103f into master Oct 23, 2024
34 checks passed
@cstuncsik cstuncsik deleted the pay-2056-community-issue-select-all-finished-executions-delete-off-by branch October 23, 2024 10:46
Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixes the issue. Thanks.

Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions github-actions bot mentioned this pull request Oct 24, 2024
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with n8n@1.65.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select all finished executions -> Delete -> off by 1
4 participants