Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update required node js version in CONTRIBUTING.md #11437

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: Update required node js version in CONTRIBUTING.md #11437

merged 1 commit into from
Oct 29, 2024

Conversation

ShireenMissi
Copy link
Contributor

@ShireenMissi ShireenMissi commented Oct 28, 2024 •
edited
Loading

Summary

in contribution guides we mention 18.10 as the minimum required Node js version, however pnpm 9.x requires 18.12 as the minimum and we require 20.15 as the minimum node js version for development
here is the error you get by running pnpm on 18.10

pnpm build
ERROR: This version of pnpm requires at least Node.js v18.12
The current version of Node.js is v18.10.0

This PR updates contribution.md to avoid confusion

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1932/update-contributingmd-with-minimum-node-version
#10002

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

netroy
netroy requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For development, we already require versions above 20.15

ShireenMissi
ShireenMissi commented Oct 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Oct 28, 2024
@ShireenMissi ShireenMissi force-pushed the node-1932-update-contributingmd-with-minimum-node-version branch from e8f7c68 to da41a8a Compare October 29, 2024 08:37
netroy
netroy approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ShireenMissi ShireenMissi merged commit 4f511aa into master Oct 29, 2024
16 checks passed
@ShireenMissi ShireenMissi deleted the node-1932-update-contributingmd-with-minimum-node-version branch October 29, 2024 08:54
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Merged
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with n8n@1.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShireenMissi @janober @netroy