Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix adding connections when initializing workspace in templates view on new canvas #11451

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Oct 29, 2024

Summary

  1. Enable templates view by running export N8N_TEMPLATES_ENABLED=true
  2. Go to /templates/2454
  3. Check that connections are added
Screen.Recording.2024-10-29.at.15.38.48.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7874/template-pages-not-loading-connections

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 29, 2024
Copy link

cypress bot commented Oct 29, 2024

n8n    Run #7610

Run Properties:  status check passed Passed #7610  •  git commit c55049db34: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7874-template-pages-not-loading-connections
Run status status check passed Passed #7610
Run duration 04m 33s
Commit git commit c55049db34: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit ea47b02 into master Oct 29, 2024
34 checks passed
@alexgrozav alexgrozav deleted the n8n-7874-template-pages-not-loading-connections branch October 29, 2024 14:36
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with n8n@1.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants