Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix task runner sending too many offers #12415

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix(core): Fix task runner sending too many offers #12415

merged 2 commits into from
Jan 2, 2025

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Dec 31, 2024

Summary

  • Fix task runner not respecting the max concurrency setting and sending new task offers on every tick.
  • Fix task runner sending new task offers even when its shutting down

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-459/community-issue-code-node-stopped-working

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@tomi tomi force-pushed the cat-459-community-issue-code-node-stopped-working branch from 97b56c0 to 5b74cac Compare December 31, 2024 14:00
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 31, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/@n8n/task-runner/src/task-runner.ts 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

ivov
ivov approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Object.values(map) is dangerously easy to miss 🙈

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Dec 31, 2024

n8n    Run #8526

Run Properties:  status check passed Passed #8526  •  git commit 7785bca129: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review cat-459-community-issue-code-node-stopped-working
Run status status check passed Passed #8526
Run duration 04m 44s
Commit git commit 7785bca129: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

@tomi tomi merged commit 4498e35 into master Jan 2, 2025
37 checks passed
@tomi tomi deleted the cat-459-community-issue-code-node-stopped-working branch January 2, 2025 08:16
@tomi tomi added the release/backport Changes that need to be backported to older releases. label Jan 2, 2025
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
@tomi @riascho
fix(core): Fix task runner sending too many offers (#12415)
fd60fdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomi @janober @ivov