fix(core): Allow index as top-level item key for Code node
#12469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Jan 6, 2025
| @@ -4,7 +4,19 @@ import type { INodeExecutionData } from 'n8n-workflow'; | |||
| import { ValidationError } from './errors/validation-error'; | |||
| import { isObject } from './obj-utils'; | |||
|
|
|||
| export const REQUIRED_N8N_ITEM_KEYS = new Set(['json', 'binary', 'pairedItem', 'error']); | |||
| export const REQUIRED_N8N_ITEM_KEYS = new Set([ | |||
There was a problem hiding this comment.
we really need to setup a @n8n/constants package to reduce duplication like this.
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-473-v2
|
| Run status |
|
| Run duration | 04m 49s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
485
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
1 similar comment
|
Got released with |
|
Got released with |
1 similar comment
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
indexkey was added to theINodeExecutionDatainterface by the community, who also added it toFunctionandFunctionItem. It was then added to Gong, and very recently we added it toExecuteWorkflowTriggerandToolWorkflowV2.Until we can stop using this
indexkey in all nodes, the Code node will need to allowlist this key so that we do not throw during input data validation. This is especially relevant for a Code node run in a subworkflow execution.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-473/task-runner-code-node-fails-when-used-in-sub-workflow
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)