Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Prefix package name in supportedNodes on generated types as well #12514

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 8, 2025

Summary

Since #11329 credential testing in the frontend has been broken because the supportedNodes array has been missing in the generated types for the frontend.

Related Linear tickets, Github issues, and Community forum posts

PAY-2440

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/load-nodes-and-credentials.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy force-pushed the fix-PAY-2440-supportedNodes branch from 4c44496 to 8afb48d Compare January 9, 2025 19:31
@netroy netroy force-pushed the fix-PAY-2440-supportedNodes branch from 8afb48d to 441cac0 Compare January 14, 2025 15:39
@netroy netroy marked this pull request as ready for review January 14, 2025 15:42
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 15, 2025

n8n    Run #8760

Run Properties:  status check passed Passed #8760  •  git commit 3f825dbbf2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-PAY-2440-supportedNodes
Run status status check passed Passed #8760
Run duration 04m 49s
Commit git commit 3f825dbbf2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 4a1a999 into master Jan 15, 2025
37 checks passed
@ivov ivov deleted the fix-PAY-2440-supportedNodes branch January 15, 2025 12:06
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
@janober
Copy link
Member

janober commented Jan 15, 2025

Got released with n8n@1.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants