-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Prefix package name in supportedNodes
on generated types as well
#12514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Jan 8, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
netroy
force-pushed
the
fix-PAY-2440-supportedNodes
branch
from
January 9, 2025 19:31
4c44496
to
8afb48d
Compare
netroy
force-pushed
the
fix-PAY-2440-supportedNodes
branch
from
January 14, 2025 15:39
8afb48d
to
441cac0
Compare
cstuncsik
approved these changes
Jan 15, 2025
|
n8n Run #8760
Run Properties:
|
Project |
n8n
|
Branch Review |
fix-PAY-2440-supportedNodes
|
Run status |
Passed #8760
|
Run duration | 04m 49s |
Commit |
3f825dbbf2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
489
|
View all changes introduced in this branch ↗︎ |
|
ivov
approved these changes
Jan 15, 2025
✅ All Cypress E2E specs passed |
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #11329 credential testing in the frontend has been broken because the
supportedNodes
array has been missing in the generated types for the frontend.Related Linear tickets, Github issues, and Community forum posts
PAY-2440
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)