Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Swap Activate/Deactivate texts in FloatingToolbar #12526

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Jan 9, 2025

Summary

Before:

image

After:

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3074/community-issue-floating-toolbar-power-state
#12515

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb marked this pull request as ready for review January 9, 2025 11:16
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...onents/canvas/elements/nodes/CanvasNodeToolbar.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 9, 2025
Copy link

cypress bot commented Jan 9, 2025

n8n    Run #8675

Run Properties:  status check passed Passed #8675  •  git commit 74af2165be: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review ADO-3074
Run status status check passed Passed #8675
Run duration 04m 58s
Commit git commit 74af2165be: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ All Cypress E2E specs passed

@CharlieKolb CharlieKolb changed the title fix(editor): Swap Activate/Deactivate texts fix(editor): Swap Activate/Deactivate texts in FloatingToolbar Jan 9, 2025
@CharlieKolb CharlieKolb merged commit 44679b4 into master Jan 9, 2025
39 checks passed
@CharlieKolb CharlieKolb deleted the ADO-3074 branch January 9, 2025 12:02
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
@janober
Copy link
Member

janober commented Jan 15, 2025

Got released with n8n@1.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants