fix(core): Improve cyclic dependency check in the DI container #12600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
netroy
force-pushed
the
another-di-circular-dependency-check
branch
from
71885e0 to
1fd26c2
Compare
tomi
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
another-di-circular-dependency-check
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
|
|
…-dependency-check
tomi
approved these changes
Jan 15, 2025
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous cyclic dependency check wasn't working. This PR fixes that, and adds tests to ensure that the check works, and that we log the dependency chain to stdout, when the check fails.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)