fix touchscreen bug #3206
Merged
fix touchscreen bug #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
reviewed
Apr 26, 2022
| @@ -3,7 +3,8 @@ import Vue from 'vue'; | |||
| export const deviceSupportHelpers = Vue.extend({ | |||
| data() { | |||
| return { | |||
| isTouchDevice: 'ontouchstart' in window || navigator.maxTouchPoints, | |||
| // @ts-ignore msMaxTouchPoints is deprecated but must fix tablet bugs before fixing this.. otherwise breaks touchscreen computers | |||
| isTouchDevice: 'ontouchstart' in window || navigator.msMaxTouchPoints, | |||
There was a problem hiding this comment.
Oddly, msMaxTouchPoints and platform are both deprecated but msMaxTouchPoints returns undefined and platform still returns a string. Wondering if we might have an issue once platform starts returning undefined.
There was a problem hiding this comment.
yes would have to handle platform separately as tech debt
|
Thanks a lot. Got merged. |
janober
added
core
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting ts related changes 027dfb2#diff-3d3c041f8ea21c808cb848b1e406293cfb11c9b09c68b67b81389ea0469db1a9R6
fixes #3167
Community Issue:
https://community.n8n.io/t/172-0-nodes-position-not-saved/13082/6