Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows to ignore Notion URL properties if empty #3564

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Allows to ignore Notion URL properties if empty #3564

merged 5 commits into from
Jul 20, 2022

Conversation

baflo
Copy link
Contributor

@baflo baflo commented Jun 20, 2022

This PR addresses a problem shown in https://community.n8n.io/t/notion-integration-got-created/3522/23?u=baflo

It adds an option to Notion properties of type url that allows to not send the property to Notion API if no value is set.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Jun 20, 2022
@baflo
Copy link
Contributor Author

baflo commented Jun 27, 2022

How can I help so this will be accepted?

agobrech
agobrech suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @baflo, thanks for the changes just a small fix: the option is not in the correct location. They have to be alphabetically sorted. After that we can merge it 👍.

@janober janober merged commit 6cb9aef into n8n-io:master Jul 20, 2022
@janober
Copy link
Member

janober commented Jul 20, 2022

Thanks a lot for your contribution @agobrech! Just got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Jul 20, 2022
@janober
Copy link
Member

janober commented Jul 20, 2022

Got released with n8n@0.187.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jul 20, 2022
@baflo baflo deleted the n8n-notion-ignore-if-empty branch July 21, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baflo @CLAassistant @janober @agobrech