SendInBlue Nodes #3746
Merged
SendInBlue Nodes #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brianinoa
commented
Jul 20, 2022
•
brianinoa
commented
- SendInBlue Declarative Node
- https://linear.app/n8n/issue/N8N-3789/sendinblue-node-implementation
- SendInBlue Trigger Node
- https://linear.app/n8n/issue/N8N-3856/sendinblue-trigger-node
♻️ Introduce override for createAttribute selectedCategory ♻️ Add delete functionality
⚡ Update request url for contact delete
⚡ Add Model file and TransactionalEmail interface
♻️ Make Identifier required
janober
reviewed
Jul 26, 2022
krynble
suggested changes
Jul 28, 2022
There was a problem hiding this comment.
I've found some more issues, can you please fix them @brianinoa ?
Afterwards I think it's worth running a quick check on all resources and operations just to make sure it's 100%, I haven't done so in this run.
…o/n8n into n8n-3856-sendinblue-trigger-node
|
Thanks a lot. Got merged. |
|
Got released with |
brianinoa
added a commit
that referenced
this pull request
Aug 5, 2022
* add sendinblue svg icon * Add code and required files for new sendinblue node * Add node to package.json * Update credentials to display API Key instead of Access Token * Use new svg found in brandfetch * ⚡ Improvements * ♻️ Moved descriptions for email to it's own file * ⚡ Added support for contact get * ⚡ moved email descriptions to it's own file * ⚡ Add logic to conditionally remove/format sms,email * ⚡ Improvements * ⚡ Refactor Sender descriptions to it's own file * ⚡ Fix urls * ⚡ Improvements attempt * ⚡ Refactor remove inline descriptions * ⚡ Minor improvement * 🎨 Learn a nice way to send options as key-value * ⚡ Improvements * ♻️ Fix Create Operation structure * ♻️ Refactor create functionality for attribute ♻️ Introduce override for createAttribute selectedCategory ♻️ Add delete functionality * 🔥 Remove preSend from delete * ⚡ Implement override for body types * ⚡ Cleanup node file * ⚡ Update response for contact update ⚡ Update request url for contact delete * ⚡ Add presend check for optional properties that are empty ⚡ Add Model file and TransactionalEmail interface * ⚡ formatting * ♻️ Remove requestOperations from Node Description level * ♻️ Cleanup routing for Get All ♻️ Make Identifier required * ⚡ Formatting * ♻️ Add Options Collection * ♻️ Add Filters area * ♻️ Formatting * ♻️ Handle empty return * ♻️ Remove unused code * ♻️ Fix pagination ♻️ Fix empty return for delete * ⚡ Add pagination * ⚡ Fix Modified Since * ♻️ Reorder send operation ui * ⚡ Remove no longer needed presend ⚡ Add send html template operation * ♻️ Make Contact Attribute name and type required * ♻️ Rename Attribute to Contact Attribute * ♻️ Rename Identifier to Contact Identifier * ♻️ Remove SMS from root level because it can exist in Contact Attributes * ♻️ Fix Array type using 'Array<T>' ♻️ Fix double quotes should be single quotes * 👕 Lint Fix * ⚡ Add email attachment functionality ⚡ Add attachment data validation * ⚡ Add dynamic loading of Email Template IDs * ♻️ Cleanup validation method * ⚡ Introduce workaround and use binary data for attachments * feat: Migrated to npm release of riot-tmpl fork. * 👕 Lint fix rules * 👕 Lint fix rules * fix: Updated imports to use @n8n_io/riot-tmpl * fix: Fixed Logger.ts types. * ⚡ Fix mixmatch of filename and package.json credentials list * ⚡ fix mixmatch in nodes list * feat(core): Give access to getBinaryDataBuffer in preSend method * ⚡ clean up mixmatches in node naming * ♻️ Refactor code to use newly exposed getBinaryDataBuffer method * ⚡ Improvements * 🔥 Remove unnecessary lines * 👕 Fix linting issues * ⚡ Fix issues with up to date APIs and improve readability * ⚡ update naming of files * ♻️ Move sendHtml boolean above subject ♻️ Update naming from Parameters to Fields * ♻️ Move sendHtml boolean above subject ♻️ Update naming from Parameters to Fields * ♻️ Add attribute name url encoding ♻️ Change limit's default to 50 * ⚡ Fix default for templateId * ⚡ Fix display name for attribute list * ♻️ Add clarity to attribute value display name * ♻️ Add tags and attachments for emails * ♻️ Add use of item's binary data fileName * 👕 Fix action lint rule * 👕 Remove deprecated lint rule * ⬆️ Update eslint-plugin-n8n-nodes-base * 👕 Fix lint rule for file name * ⚡ Fix update attribute * ♻️ Add upsert capabilites * 🔥 Remove create or update operation * ♻️ Add sendInBlueWebhookApi namespace * ♻️ Add Webhook API functionality * ⚡ Add SendInBlue Trigger * ⚡ Return correct webhookId data * ⚡ Add placeholder for receiving data * 👕 Fixing existing linting issues * 🚨 Enable namespacing in tslint file * 👕 Fix linting issues * ⚡ Rename exported WebhookApi * 🔥 Remove unused Model.ts file * ♻️ Update node to use SendInBlue namespace * ⚡ Revert back to allowing upsert functionality * ♻️ Fix options to better describe events * Remove update flag for create operation * ♻️ Fix discrepancies for contact resource * remove no-namespace lint rule * 👕 Fix linting issues * ♻️ Add sendInBlueWebhookApi namespace * ♻️ Add Webhook API functionality * ⚡ Add SendInBlue Trigger * ⚡ Return correct webhookId data * ⚡ Add placeholder for receiving data * 👕 Fix linting issues * ⚡ Rename exported WebhookApi * ♻️ Fix options to better describe events * Add optionswithuri import that was lost * ⚡ Fix details from janober's review * ⚡ Fix order of displayName and name properties * ⚡ Fix default value and improve loadOptions * ⚡ Introduce support for comma separated attribute values * ⚡ Introduce support for comma separated attribute values * 👕 Fix linting issues * Update defaults and required props * ⚡ Fix copy paste issue Upsert was not using correct endpoint * ⚡ Fix upsert email field display name * ⚡ Last update, upsert email description * ⚡ Add PostReceived type limit Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
brianinoa
added a commit
that referenced
this pull request
Aug 5, 2022
* add sendinblue svg icon * Add code and required files for new sendinblue node * Add node to package.json * Update credentials to display API Key instead of Access Token * Use new svg found in brandfetch * ⚡ Improvements * ♻️ Moved descriptions for email to it's own file * ⚡ Added support for contact get * ⚡ moved email descriptions to it's own file * ⚡ Add logic to conditionally remove/format sms,email * ⚡ Improvements * ⚡ Refactor Sender descriptions to it's own file * ⚡ Fix urls * ⚡ Improvements attempt * ⚡ Refactor remove inline descriptions * ⚡ Minor improvement * 🎨 Learn a nice way to send options as key-value * ⚡ Improvements * ♻️ Fix Create Operation structure * ♻️ Refactor create functionality for attribute ♻️ Introduce override for createAttribute selectedCategory ♻️ Add delete functionality * 🔥 Remove preSend from delete * ⚡ Implement override for body types * ⚡ Cleanup node file * ⚡ Update response for contact update ⚡ Update request url for contact delete * ⚡ Add presend check for optional properties that are empty ⚡ Add Model file and TransactionalEmail interface * ⚡ formatting * ♻️ Remove requestOperations from Node Description level * ♻️ Cleanup routing for Get All ♻️ Make Identifier required * ⚡ Formatting * ♻️ Add Options Collection * ♻️ Add Filters area * ♻️ Formatting * ♻️ Handle empty return * ♻️ Remove unused code * ♻️ Fix pagination ♻️ Fix empty return for delete * ⚡ Add pagination * ⚡ Fix Modified Since * ♻️ Reorder send operation ui * ⚡ Remove no longer needed presend ⚡ Add send html template operation * ♻️ Make Contact Attribute name and type required * ♻️ Rename Attribute to Contact Attribute * ♻️ Rename Identifier to Contact Identifier * ♻️ Remove SMS from root level because it can exist in Contact Attributes * ♻️ Fix Array type using 'Array<T>' ♻️ Fix double quotes should be single quotes * 👕 Lint Fix * ⚡ Add email attachment functionality ⚡ Add attachment data validation * ⚡ Add dynamic loading of Email Template IDs * ♻️ Cleanup validation method * ⚡ Introduce workaround and use binary data for attachments * feat: Migrated to npm release of riot-tmpl fork. * 👕 Lint fix rules * 👕 Lint fix rules * fix: Updated imports to use @n8n_io/riot-tmpl * fix: Fixed Logger.ts types. * ⚡ Fix mixmatch of filename and package.json credentials list * ⚡ fix mixmatch in nodes list * feat(core): Give access to getBinaryDataBuffer in preSend method * ⚡ clean up mixmatches in node naming * ♻️ Refactor code to use newly exposed getBinaryDataBuffer method * ⚡ Improvements * 🔥 Remove unnecessary lines * 👕 Fix linting issues * ⚡ Fix issues with up to date APIs and improve readability * ⚡ update naming of files * ♻️ Move sendHtml boolean above subject ♻️ Update naming from Parameters to Fields * ♻️ Move sendHtml boolean above subject ♻️ Update naming from Parameters to Fields * ♻️ Add attribute name url encoding ♻️ Change limit's default to 50 * ⚡ Fix default for templateId * ⚡ Fix display name for attribute list * ♻️ Add clarity to attribute value display name * ♻️ Add tags and attachments for emails * ♻️ Add use of item's binary data fileName * 👕 Fix action lint rule * 👕 Remove deprecated lint rule * ⬆️ Update eslint-plugin-n8n-nodes-base * 👕 Fix lint rule for file name * ⚡ Fix update attribute * ♻️ Add upsert capabilites * 🔥 Remove create or update operation * ♻️ Add sendInBlueWebhookApi namespace * ♻️ Add Webhook API functionality * ⚡ Add SendInBlue Trigger * ⚡ Return correct webhookId data * ⚡ Add placeholder for receiving data * 👕 Fixing existing linting issues * 🚨 Enable namespacing in tslint file * 👕 Fix linting issues * ⚡ Rename exported WebhookApi * 🔥 Remove unused Model.ts file * ♻️ Update node to use SendInBlue namespace * ⚡ Revert back to allowing upsert functionality * ♻️ Fix options to better describe events * Remove update flag for create operation * ♻️ Fix discrepancies for contact resource * remove no-namespace lint rule * 👕 Fix linting issues * ♻️ Add sendInBlueWebhookApi namespace * ♻️ Add Webhook API functionality * ⚡ Add SendInBlue Trigger * ⚡ Return correct webhookId data * ⚡ Add placeholder for receiving data * 👕 Fix linting issues * ⚡ Rename exported WebhookApi * ♻️ Fix options to better describe events * Add optionswithuri import that was lost * ⚡ Fix details from janober's review * ⚡ Fix order of displayName and name properties * ⚡ Fix default value and improve loadOptions * ⚡ Introduce support for comma separated attribute values * ⚡ Introduce support for comma separated attribute values * 👕 Fix linting issues * Update defaults and required props * ⚡ Fix copy paste issue Upsert was not using correct endpoint * ⚡ Fix upsert email field display name * ⚡ Last update, upsert email description * ⚡ Add PostReceived type limit Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.